Add store delete command by alfonso-noriega · Pull Request #8035 · Shopify/cli

alfonso-noriega · 2026-07-08T11:08:35Z

WHY are these changes introduced?

Fixes https://github.com/shop/issues-develop/issues/22936

Shopify CLI needs a CLI-side shopify store delete command for app development stores. Business Platform now accepts app development store deletion requests by calling Core billingCloseShop(immediate: true), but Core cancellation completes asynchronously and BP no longer eagerly removes the BP Shop row. Because mutation success means “close request accepted”, the CLI must wait for the authoritative cancellation signal from Organizations API instead of treating row disappearance as success.

WHAT is this pull request doing?

Adds a hidden shopify store delete command in @shopify/store for deleting development stores.
Supports the command flag shape: global flags, --json, --store, and --organization-id.
Adds the deleteAppDevelopmentStore Business Platform mutation document and typed document.
Resolves the target store’s shopifyShopId using the existing Organizations API accessible shops lookup before polling.
After a successful delete mutation, polls organization.accessibleShop(id:) until planName is exactly cancelled.
Keeps delete mutation user error handling unchanged and does not poll when the mutation returns user errors.
Uses bounded polling consistent with development store creation polling, and reports deletion as requested but not confirmed if cancellation is still asynchronous at timeout.
Treats a null accessibleShop response as inconclusive rather than confirmed cancellation.
Registers the command in the store plugin and CLI oclif manifest.
Adds tests for successful cancellation confirmation, mutation user errors, timeout behavior, and null accessibleShop polling responses.

How to test your changes?

Tophat:

Enable the backend store-create/delete CLI flag (f_cli_store_create_enabled) for your organization.

From this branch, create a new development store through the local CLI:

pnpm shopify store create dev --name <store-name> --organization-id <organization-id> --plan plus

Confirm the store appears in Dev Dashboard: https://dev.shopify.com/dashboard/<organization-id>/stores.
From this branch, run the new delete command through the local CLI:
```
pnpm shopify store delete --store <store-subdomain>.myshopify.com
```
Confirm the command reports the deletion request/confirmation and that the development store is no longer active in Dev Dashboard.

Automated checks:

pnpm --filter @shopify/store vitest run src/cli/commands/store/delete.test.ts src/cli/services/store/delete/dev.test.ts src/cli/utilities/store-lookup/organization-shop.test.ts
pnpm --filter @shopify/store lint
pnpm --filter @shopify/store type-check

Post-release steps

None.

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes
I've considered analytics changes to measure impact
The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

alfonso-noriega · 2026-07-08T11:08:49Z

Add store delete command #8035 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

alexCevi · 2026-07-09T04:41:44Z

This has been NEEDED!

alfonso-noriega · 2026-07-13T10:17:57Z

/snapit

alfonso-noriega · 2026-07-13T10:44:16Z

/snapit

isaacroldan

Review assisted by pair-review

Assisted-By: devx/921acb10-d127-42c8-8a9a-0314a325d188

gonzaloriestra · 2026-07-24T11:55:50Z

/snapit

github-actions · 2026-07-24T11:59:25Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260724115655

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

gonzaloriestra

I guess it's a backend issue, but the confirmation timed out:

❯ shopify store delete --store dev-store-cli.myshopify.com

╭─ warning ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                                           │
│  Development store "dev-store-cli.myshopify.com" deletion was requested, but not confirmed.                                                               │
│                                                                                                                                                           │
│  Shopify accepted the deletion request, but deletion was not confirmed before the CLI stopped waiting. The store may still finish deleting                │
│  asynchronously.                                                                                                                                          │
│                                                                                                                                                           │
╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

I got an email about the store being closed and when I open admin it says You can’t access this store because it’s frozen. However, it's still listed in Dev Dashboard. I'll check later if it's still there.

gonzaloriestra · 2026-07-24T12:45:38Z

+  static flags = {
+    ...globalFlags,
+    ...jsonFlag,
+    store: storeFlags.store,


I see this flag is required, but I think we could prompt when the flag is missing. The issue is common to all the store commands, so no need to fix it now, but I think we should improve it.

gonzaloriestra · 2026-07-24T12:48:46Z

+
+  async run(): Promise<void> {
+    const {flags} = await this.parse(StoreDelete)
+    this.failMissingNonTTYFlags(flags, ['store'])


The flag is required, so this is not needed, no?

gonzaloriestra · 2026-07-24T12:51:08Z

+    const {flags} = await this.parse(StoreDelete)
+    this.failMissingNonTTYFlags(flags, ['store'])
+
+    const organization = await organizationForStoreDeletion(flags.store, flags['organization-id']?.toString())


If there's an error here, it will show a regular abort when the --json flag is provided. Not a big deal because we are not handling as expected yet json errors everywhere. But I think we could solve it by moving it inside the try-catch.

github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 8, 2026

alfonso-noriega marked this pull request as ready for review July 8, 2026 11:09

alfonso-noriega requested review from a team as code owners July 8, 2026 11:09

isaacroldan reviewed Jul 9, 2026

View reviewed changes

Comment thread packages/store/src/cli/commands/store/delete.ts Outdated

isaacroldan reviewed Jul 9, 2026

View reviewed changes

Comment thread packages/store/src/cli/commands/store/delete.ts Outdated

alfonso-noriega force-pushed the store-delete-dev branch from c4ddb40 to 274afea Compare July 9, 2026 14:09

isaacroldan approved these changes Jul 9, 2026

View reviewed changes

alfonso-noriega force-pushed the store-delete-dev branch from 274afea to f110d2c Compare July 13, 2026 10:17

alfonso-noriega force-pushed the store-delete-dev branch 2 times, most recently from 437d91f to 11125b5 Compare July 16, 2026 13:35

github-actions Bot added Area: @shopify/cli @shopify/cli package issues and removed no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. labels Jul 16, 2026

isaacroldan reviewed Jul 16, 2026

View reviewed changes

Comment thread .changeset/confirm-store-cancellation.md Outdated

isaacroldan reviewed Jul 16, 2026

View reviewed changes

Comment thread packages/store/src/cli/services/store/info/organization-shop.ts Outdated

isaacroldan reviewed Jul 16, 2026

View reviewed changes

Comment thread packages/store/src/cli/services/store/delete/dev.ts

isaacroldan reviewed Jul 16, 2026

View reviewed changes

Comment thread packages/store/src/cli/services/store/delete/dev.ts Outdated

alfonso-noriega force-pushed the store-delete-dev branch 2 times, most recently from 56031ae to 638480a Compare July 16, 2026 16:22

github-actions Bot added no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. and removed Area: @shopify/cli @shopify/cli package issues labels Jul 16, 2026

alfonso-noriega force-pushed the store-delete-dev branch 5 times, most recently from 890d637 to be5255b Compare July 21, 2026 18:51

alfonso-noriega force-pushed the store-delete-dev branch from be5255b to af8142a Compare July 22, 2026 14:18

Add store delete command

d27e901

Assisted-By: devx/921acb10-d127-42c8-8a9a-0314a325d188

alfonso-noriega force-pushed the store-delete-dev branch from af8142a to d27e901 Compare July 22, 2026 14:48

alfonso-noriega requested review from amcaplan, dmerand and gonzaloriestra July 22, 2026 14:54

dmerand approved these changes Jul 23, 2026

View reviewed changes

gonzaloriestra approved these changes Jul 24, 2026

View reviewed changes

Uh oh!

Conversation

alfonso-noriega commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Checklist

Uh oh!

alfonso-noriega commented Jul 8, 2026

Uh oh!

alexCevi commented Jul 9, 2026

Uh oh!

Uh oh!

Uh oh!

alfonso-noriega commented Jul 13, 2026

Uh oh!

alfonso-noriega commented Jul 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isaacroldan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gonzaloriestra commented Jul 24, 2026

Uh oh!

github-actions Bot commented Jul 24, 2026

Uh oh!

gonzaloriestra left a comment

Choose a reason for hiding this comment

Uh oh!

gonzaloriestra Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

gonzaloriestra Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

gonzaloriestra Jul 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alfonso-noriega commented Jul 8, 2026 •

edited

Loading